fix(tracing): Don't throw error logs in valid scenarios #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While analyzing canonical/grafana-agent-operator#219 with @michaeldmitry in the context of the k8s charm, we realized some of the logs might be misleading. If the tracing provider cannot (yet) serve any of the requested protocols, the expected outcome would be to return an empty list. Tracing consumer will then throw an error log the charm operator cannot do anything about.
Also we noticed we have an inconsistency in the behaviour when more than 1 receiver of the same protocol would be returned: the log says we're returning the first entry, the actual behaviour is that we exit early.
Solution
Reduce the logs severity and allow to return the first matching receiver.
Context
Testing Instructions
Upgrade Notes