Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Don't throw error logs in valid scenarios #95

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mmkay
Copy link
Contributor

@mmkay mmkay commented Dec 18, 2024

Issue

While analyzing canonical/grafana-agent-operator#219 with @michaeldmitry in the context of the k8s charm, we realized some of the logs might be misleading. If the tracing provider cannot (yet) serve any of the requested protocols, the expected outcome would be to return an empty list. Tracing consumer will then throw an error log the charm operator cannot do anything about.

Also we noticed we have an inconsistency in the behaviour when more than 1 receiver of the same protocol would be returned: the log says we're returning the first entry, the actual behaviour is that we exit early.

Solution

Reduce the logs severity and allow to return the first matching receiver.

Context

Testing Instructions

Upgrade Notes

@mmkay mmkay merged commit 0cdd304 into main Dec 19, 2024
14 checks passed
@mmkay mmkay deleted the fix/tracing-logs branch December 19, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants