Adds whereabouts rock #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the Dockerfile: https://github.com/k8snetworkplumbingwg/whereabouts/blob/v0.6.3/Dockerfile Using [email protected] as a base since we're supposed to run /install-cni.sh, which needs to run commands. Additionally, not running as _daemon_, as it may need root access for some of the operations.
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
claudiubelu
force-pushed
the
adds-whereabouts-rock
branch
2 times, most recently
from
28eed33
to
6622950
Compare
claudiubelu
force-pushed
the
adds-whereabouts-rock
branch
from
6622950
to
7fa39f4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Dockerfile: https://github.com/k8snetworkplumbingwg/whereabouts/blob/v0.6.3/Dockerfile
Using
[email protected]as a base since we're supposed to run/install-cni.sh, which needs to run commands.Additionally, not running as
_daemon_, as it may need root access for some of the operations.