Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the automatic use of our internal swtfb client by setting an env #118

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Allow disabling the automatic use of our internal swtfb client by setting an env #118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53605b2
Check env when using Framebuffer::new() or Default trait to auto-sele…
LinusCDE Jan 26, 2024
a666f29
Fix compilation issue
LinusCDE Jan 26, 2024
3933c02
Update src/framebuffer/core.rs
fenollp Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/framebuffer/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ impl Framebuffer {
let device = &*device::CURRENT_DEVICE;
match device.model {
Model::Gen1 => Framebuffer::device(device.get_framebuffer_path()),
Model::Gen2 => Framebuffer::rm2fb(device.get_framebuffer_path()),
Model::Gen2 => {
// Auto-select old method still if env LIBREMARKABLE_FB_DISFAVOR_INTERNAL_RM2FB is set affirmatively
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a mention in the README about this behavior plz?

match std::env::var("LIBREMARKABLE_FB_DISFAVOR_INTERNAL_RM2FB").ok() {
Some("1") => Framebuffer::device(device.get_framebuffer_path()),
_ => Framebuffer::rm2fb(device.get_framebuffer_path()),
}
}
}
}

Expand Down
Loading