This repository has been archived by the owner on Feb 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
CoffeeScript rewrite + Added an onError setting to the initial call #21
Open
hiddentao
wants to merge
15
commits into
caolan:master
Choose a base branch
from
hiddentao:error_handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…main' and make the cookie 'secure' as well as 'max-age' will be sent if useMaxAge is true. Just to be complete, I made it so that you could also selectively turn on/off setting 'expires' and 'HttpOnly' with useExpires and useHttpOnly options, but the defaults shouldn't change any existing uses of cookie-sessions, except that useMaxAge is true by default.
…kes it work with existing unit tests and probably a little more semantically correct.
…milliseconds, not in seconds.
Updated test code to work with node 0.6.5 (require.paths.push no longer supported). All tests pass.
…hen the cookie-session will throw errors as normal. If instead a function is provided for this setting then that function will recieve a callback with the Error object.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started off by merging publickeating's excellent work (#14) and then went onto rewrite the code in CoffeeScript - the code easier to read and it makes it easier to ensure generated code is JSLint compliant. A Cakefile is included to generate the
lib/cookie-sessions.js
file. I ran all the tests to make sure everything still works as expected.I then added an onError setting. By default it's null, in which case Errors are thrown as normal. If a function is provided then that function is called instead with the Error object representing the error. Tests have been added for using onError with all existing error messages.
Example for onError: