Skip to content
This repository has been archived by the owner on Feb 3, 2020. It is now read-only.

CoffeeScript rewrite + Added an onError setting to the initial call #21

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

hiddentao
Copy link

I started off by merging publickeating's excellent work (#14) and then went onto rewrite the code in CoffeeScript - the code easier to read and it makes it easier to ensure generated code is JSLint compliant. A Cakefile is included to generate the lib/cookie-sessions.js file. I ran all the tests to make sure everything still works as expected.

I then added an onError setting. By default it's null, in which case Errors are thrown as normal. If a function is provided then that function is called instead with the Error object representing the error. Tests have been added for using onError with all existing error messages.

Example for onError:

    sessions({
        ...
        onError: function(err) {
            // e.g. err.toString() -> "Error: Invalid cookie"
        }
    });

publickeating and others added 15 commits May 13, 2011 09:30
…main' and make the cookie 'secure' as well as 'max-age' will be sent if useMaxAge is true. Just to be complete, I made it so that you could also selectively turn on/off setting 'expires' and 'HttpOnly' with useExpires and useHttpOnly options, but the defaults shouldn't change any existing uses of cookie-sessions, except that useMaxAge is true by default.
…kes it work with existing unit tests and probably a little more semantically correct.
Updated test code to work with node 0.6.5 (require.paths.push no longer supported). All tests pass.
…hen the cookie-session will throw errors as normal. If instead a function is provided for this setting then that function will recieve a callback with the Error object.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants