Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unit test of service api for draft-enabled entity. #131

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Revert unit test of service api for draft-enabled entity. #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/integration/service-api.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,9 @@ describe("change log integration test", () => {
},
],
};
await INSERT.into(adminService.entities.BookStores).entries(bookStoreData);

// REVISIT: CAP currently does not support run queries on the draft-enabled entity on application service (details in CAP/Issue#16292)
// await adminService.run(INSERT.into(adminService.entities.BookStores).entries(bookStoreData));
// CAP currently support run queries on the draft-enabled entity on application service, so we can re-enable it. (details in CAP/Issue#16292)
await adminService.run(INSERT.into(adminService.entities.BookStores).entries(bookStoreData));

let changes = await SELECT.from(ChangeView).where({
entity: "sap.capire.bookshop.BookStores",
Expand Down Expand Up @@ -432,10 +431,9 @@ describe("change log integration test", () => {
validOn: "2022-01-01",
},
};
await INSERT.into(adminService.entities.BookStores).entries(bookStoreData);

// REVISIT: CAP currently does not support run queries on the draft-enabled entity on application service (details in CAP/Issue#16292)
// await adminService.run(INSERT.into(adminService.entities.BookStores).entries(bookStoreData));
// CAP currently support run queries on the draft-enabled entity on application service, so we can re-enable it. (details in CAP/Issue#16292)
await adminService.run(INSERT.into(adminService.entities.BookStores).entries(bookStoreData));

let changes = await SELECT.from(ChangeView).where({
entity: "sap.capire.bookshop.BookStoreRegistry",
Expand Down
Loading