-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flattened readme #32
Flattened readme #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel, looks great! 👍 I like that you now have the calesi alternative if you want to skip the step-by-step and jump right in.
One thing though, I believe we still need the header ##About this project
to ensure OSS compliance.
@sjvans: Could you please comment on the structure that was requested for the README which you also adhered to in @cap-js/audit-logging?
i'll send you some internal links via chat ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm afraid we'll need to retain .reuse
and LICENSES
@sjvans: Thanks for the links! 👍 According to the repo linting tool, we should still have a section called Warning [rl-readme_file-2] README is incomplete. Please check the following sections: Requirements |
not a must. however, the tool only lints main, so you'll need to merge this first to see if there are new violations. |
Let's discuss that in our next sync. |
We should also add a disclaimer on the top that this is Early Adopters and production use is on your own risk. |
We've addressed this here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
No description provided.