-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create Global switch for preserveDelete #96
Conversation
Corrected this to the change-tracking flag...
…ed in the generated changelog.
Hallo @Sv7enNowitzki otherwise, this looks coprehensive, especially the test coverage... |
Hi @nkaputnik , I should have provided a description in the PR, apologies for any confusion caused... In this PR, the modifications specifically targeted towards the global switch functionality are reflected only in change-log.js. The behavior is as follows:
The code modifications made in entity-helper.js are for the purpose that the generated changelog is correct, aligns with our expectations when deleting the root entity. However, there was skewness in the ObjectID retrieval behaviors, and the code amendments in this file are directed towards fixing this bug. Of course, if committing in this way is impractical, I can split and submit this as two separate PRs. Indeed, that seems more rational. Best Regards, |
No, that's good, I'll merge this PR and update readme and release notes... |
No description provided.