Remove stream parameters for now #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vocal-profiterole-b755d1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bendecoste
reviewed
Sep 27, 2023
| { | ||
| "request": { | ||
| "prompt": prompt, | ||
| "stream": True, |
There was a problem hiding this comment.
We are removing the param but forcing it to true here?
There was a problem hiding this comment.
Sorry, I think my commit message is wrong. We're removing it from allowing the user to set it in the sdk because non-stream isn't supported. i.e. we want to force the sdk to use streaming.
There was a problem hiding this comment.
fixed up the commit msg.
Non-streaming isn't currently supported so force sdk to use streaming always. Also add temperature and max tokens.
justin1121
force-pushed
the
justin/remove-stream
branch
from
1a09ba2
to
9e351c9
Compare
bendecoste
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream currently isn't supported, also add temperature and max tokens.