Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSCENARIO 2.0 supported #1015

Conversation

synkrotron
Copy link
Contributor

@synkrotron synkrotron commented Aug 13, 2023

Description

We supported OpenSCENARIO 2.0 standard in this feature.
We implemented a compilation system to compile and execute osc2's code, and implemented part of the domain model.
We wrote some scenario files with .osc file extensions and each passed the test.
Please read README_OpenSCENARIO_2.0.md for more details.

Where has this been tested?

  • Platform(s): Ubuntu 20.04
  • Python version(s): 3.8.10
  • Unreal Engine version(s): UE4
  • CARLA version: 0.9.13

Possible Drawbacks

The support for the domain model is not complete, but some simple scenarios can already be implemented, such as the. osc file example in the example folder.


This change is Reviewable

@synkrotron
Copy link
Contributor Author

synkrotron commented Aug 13, 2023

@glopezdiest @germanros1987 We have re-created the PR for openscenario 2.0 support, please ignore previous one #990

@germanros1987
Copy link
Member

@joel-mb could you review this, please?

@synkrotron
Copy link
Contributor Author

We have updated the code to address the static code check.

Copy link
Contributor

@glopezdiest glopezdiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 166 of 242 files at r1, 14 of 33 files at r2, 2 of 3 files at r3, 68 of 68 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @joel-mb)

@glopezdiest
Copy link
Contributor

Hey, thanks for the amazing PR. This is definitely a huge contribution to the repo.

Overall, this looks like a pretty good addition to the repository, and while there might be some sections that can be improved, they can definitely be done in subsequent PRs without any issues. This is also a self-contained feature, so even if some errors appear, they won't affect other areas of the repo.

Again, thank you very much for all the effort, and the willingness to share it with us!

@glopezdiest glopezdiest merged commit 252b3c8 into carla-simulator:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants