Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove duplicate clean method calls #1096

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

starrye
Copy link
Contributor

@starrye starrye commented Jul 3, 2024

Description

Fixes #

Where has this been tested?

  • Platform(s): Ubuntu
  • Python version(s): 3.8
  • Unreal Engine version(s): 5
  • CARLA version: 0.9.15

Possible Drawbacks

Hello, when I added custom logic to CarlaDataProvider clean, I found that it was called many times. And I saw in Class ScenarioRunner _cleanup method calls the self.manager. cleanup () and CarlaDataProvider. cleanup (), Of the self.manager.cleanup () includes CarlaDataProvider.cleanup(), so can make CarlaDataProvider.cleanup() method is called three times, In fact, after stopping the operation in ScenarioManager.run_scenario(), self.cleanup()will be called immediately, which already containsCarlaDataProvider.cleanup(), So consider removing the redundant clean method call in the _cleanup method of the ScenarioRunner class


This change is Reviewable

@starrye
Copy link
Contributor Author

starrye commented Jul 3, 2024

@PabloVD please review

@starrye
Copy link
Contributor Author

starrye commented Nov 5, 2024

@PabloVD new commit please review Fix Atomic_behaviors AddActor Func

Copy link
Contributor

@PabloVD PabloVD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @starrye)

@PabloVD
Copy link
Contributor

PabloVD commented Nov 6, 2024

Looks ok to me, merged, thanks!

@PabloVD PabloVD merged commit 5832584 into carla-simulator:master Nov 6, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants