Fix: Remove duplicate clean method calls #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Where has this been tested?
Possible Drawbacks
Hello, when I added custom logic to CarlaDataProvider clean, I found that it was called many times. And I saw in Class
ScenarioRunner _cleanup
method calls theself.manager. cleanup ()
andCarlaDataProvider. cleanup ()
, Of theself.manager.cleanup ()
includesCarlaDataProvider.cleanup()
, so can makeCarlaDataProvider.cleanup()
method is called three times, In fact, after stopping the operation inScenarioManager.run_scenario()
,self.cleanup()
will be called immediately, which already containsCarlaDataProvider.cleanup()
, So consider removing the redundant clean method call in the _cleanup method of the ScenarioRunner classThis change is