Complete disable cache if the file is not a *_indexes

carnifexx · Jul 12, 2019 · 4da41f7 · 4da41f7
1 parent 85e91ef
commit 4da41f7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/arduino-core/src/cc/arduino/utils/network/FileDownloader.java b/arduino-core/src/cc/arduino/utils/network/FileDownloader.java
@@ -164,7 +164,7 @@ private void downloadFile(boolean noResume) throws InterruptedException {
     try {
       setStatus(Status.CONNECTING);
 
-      final Optional<FileDownloaderCache.FileCached> fileCachedOpt = FileDownloaderCache.getFileCached(downloadUrl);
+      final Optional<FileDownloaderCache.FileCached> fileCachedOpt = FileDownloaderCache.getFileCached(downloadUrl, allowCache);
       if (fileCachedOpt.isPresent()) {
         final FileDownloaderCache.FileCached fileCached = fileCachedOpt.get();
 
@@ -175,11 +175,7 @@ private void downloadFile(boolean noResume) throws InterruptedException {
         } else {
           openConnectionAndFillTheFile(noResume);
 
-          if (allowCache) {
-            fileCached.updateCacheFile(outputFile);
-          } else {
-            log.info("The file {} was not cached because allow cache is false", downloadUrl);
-          }
+          fileCached.updateCacheFile(outputFile);
         }
       } else {
         openConnectionAndFillTheFile(noResume);

diff --git a/arduino-core/src/cc/arduino/utils/network/FileDownloaderCache.java b/arduino-core/src/cc/arduino/utils/network/FileDownloaderCache.java
@@ -118,10 +118,16 @@ public class FileDownloaderCache {
   }
 
   static Optional<FileCached> getFileCached(final URL remoteURL)
+    throws URISyntaxException, NoSuchMethodException, ScriptException,
+    IOException {
+    return getFileCached(remoteURL, true);
+  }
+
+  static Optional<FileCached> getFileCached(final URL remoteURL, boolean enableCache)
     throws URISyntaxException, NoSuchMethodException, ScriptException,
     IOException {
     // Return always and empty file if the cache is not enable
-    if (!enableCache) {
+    if (!(enableCache && FileDownloaderCache.enableCache)) {
       log.info("The cache is not enable.");
       return Optional.empty();
     }