Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS-14475 #3

Merged
merged 7 commits into from
Dec 2, 2024
Merged

CAS-14475 #3

merged 7 commits into from
Dec 2, 2024

Conversation

amcnicho
Copy link
Member

@amcnicho amcnicho commented Nov 13, 2024

Fix casaconfig pip install warning due to missing pyproject.toml.

When pip installing casaconfig this deprecation warning is seen:

DEPRECATION: casaconfig is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option.

This branch replaces setup.py with pyproject.toml.

  • working build
  • CI changes
  • README/docs

@amcnicho
Copy link
Member Author

amcnicho commented Dec 2, 2024

@jmarvil has indicated that this can merge. IIUC one last commit (to change the tag back to what it should be on the main branch) is all that should be needed.

@bgarwood
Copy link
Collaborator

bgarwood commented Dec 2, 2024

@vsuorant I'll take care of this, but I want to make sure I get the sequence right before I do this. Do I approve the PR first and then edit the resulting README.md in master to get the appropriate next release (1.0.2) and then create the release here in the usual way or should the README.md be edited in this branch first, before the PR is approved?

@bgarwood bgarwood merged commit 520d236 into master Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants