Fix get user profile url #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation always used this.orgName for the required owner field, however the expected owner can be a user name, and not an org name[1]. For example, the Casdoor web app always sets the owner to "admin" [2]. This in turns make it impossible to retrieve syncers created through the web app using the SDK. This addition fixes this issue by adding an optional owner parameter to the syncer methods. [1]: https://github.com/casdoor/casdoor/blob/master/object/syncer.go#L71 [2]: https://github.com/casdoor/casdoor/blob/master/web/src/SyncerListPage.js#L30
|
@tangyang9464 @imp2002 please review |
|
Sorry, wrong commits. Opening a new one. |
|
Replaced by: #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the incorrect
}at the end of the generated profile URL when access token is provided, as well as makes accessToken explicitly optional (typings only, no runtime impact).