Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11 issue, changing LatLongCoordinatesFacet class #53

Merged
merged 1 commit into from
May 22, 2024

Conversation

fabrizio-turchi
Copy link
Contributor

@ajnelson-nist I changed also the WirelessNetworkConnectionFacet class and even though the case_validate went well, I'm not completely sure of the definition of the wirelessNetworkSecurityMode: the global range is owl:Thing but the OWL definition is vocabulary:WirelessNetworkSecurityModeVocab xsd:string.

}
)
self._node_reference_vars(**{"uco-observable:location": location})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was correct to remove. A Relationship needs to be used to tie a location to a base station. Further, the connection is not the base station.

@ajnelson-nist
Copy link
Member

@ajnelson-nist I changed also the WirelessNetworkConnectionFacet class and even though the case_validate went well, I'm not completely sure of the definition of the wirelessNetworkSecurityMode: the global range is owl:Thing but the OWL definition is vocabulary:WirelessNetworkSecurityModeVocab xsd:string.

Where did you see owl:Thing as the global range of observable:wirelessNetworkSecurityMode? The definition I see is here in UCO 1.3.0.

With what I see of the regenerated JSON-LD, your patch is fine as-is, so I'll merge it now. Please feel free to ask follow-up questions here.

@ajnelson-nist ajnelson-nist merged commit c4076f5 into casework:main May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants