Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note that set shell is not used for [script] #2468

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

iloveitaly
Copy link
Contributor

this was surprising functionality for me.

IMHO I think inheriting shell if script-interpreter is not set might be better

iloveitaly and others added 2 commits November 16, 2024 10:40
this was surprising functionality for me
@casey casey enabled auto-merge (squash) November 16, 2024 23:56
@casey casey merged commit a73c097 into casey:master Nov 16, 2024
5 checks passed
@casey
Copy link
Owner

casey commented Nov 17, 2024

Agreed it's confusing!

The reason for not using the value of set shell is that the argument to set shell is a string, whereas the argument to set script-interpreter is a path to a script. So set shell needs -c, and set script-interpreter doesn't.

@iloveitaly
Copy link
Contributor Author

Yeah, definitely makes sense once you understand that [script] essentially generates an executable file with the contents of the recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants