Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin and stately, and add linuxArm64 target #138

Closed

Conversation

jeffdgr8
Copy link

Add linuxArm64 support, as a tier 2 target. co.touchlab:stately-concurrency added linuxArm64 support in v2.0.0, which also requires Kotlin 1.9.

I migrated the stately changes on androidx-main-3.1.1 as well, but was unable to push the changes:

remote: error: Trace: 8a9ace4c1c564a70221b8d76b840b8c65dc96c7ba59e45de60097a37ac6148ed
remote: error: See https://gh.io/lfs for more information.
remote: error: File camera/gradle/wrapper/gradle-4.6-all.zip is 101.78 MB; this exceeds GitHub's file size limit of 100.00 MB
remote: error: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com.

Could you recommend how to push this branch?

The change was just sharedMutableListOf to ConcurrentMutableList.

Update stately to 2.0.0
Add linuxArm64 target
Update other dependencies
@veyndan
Copy link
Collaborator

veyndan commented Sep 21, 2023

Thanks for the PR! I'm in the midst of tracking 3.3.0-alpha02, the first version of AndroidX Paging that is KMP-compatible. The AndroidX Paging release is missing some targets still, like JS and MinGW support, hence Multiplatform Paging is continuing to track new versions of AndroidX Paging until/if AndroidX Paging targets all the targets Multiplatform Paging currently does.

Counter-intuitively, I would consider a Multiplatform Paging version of 3.3.0-alpha02 to be more stable than the Multiplatform Paging version of 3.1.1, despite the latter tracking a stable version of AndroidX Paging. The reason for this is that the amount I have to refactor in order to add all the Multiplatform Paging targets in 3.3.0-alpha02 is a lot less than that of 3.1.1, as 95% of the code is in commonMain in the latest version of AndroidX Paging, and we just have to list additional targets and workaround any oddities any platform has. Therefore, the potential for multiplatform translation issues is also a lot less when using the (soon to be released) 3.3.0-alpha02 of Multiplatform Paging.

As a result, I'm debating whether to deprecate (i.e., stop accepting contributions) to 3.1.1 and 3.2.0-alpha05. I was wondering whether you'd be okay with depending on a Multiplatform Paging version of 3.3.0-alpha02 (I can also add the linuxArm64 as part of my tracking effort)? Or is it very important to depend on 3.1.1 outside of it being a "stable" version?

@jeffdgr8
Copy link
Author

That is great to get KMP support directly in AndroidX Paging. 3.2 is also stable now, so I don't see a reason to support 3.1, at the very least. Personally I'm ok using 3.3-alpha myself as well. Looking at the change log, it appears 3.3-alpha is just 3.2 + multiplatform support, and a deprecated API I'm not using anyway.

I'm going to be releasing my KMP database library soon, with a paging extension library alongside it, which uses multiplatform-paging to support Android, JVM, iOS, macOS, Linux, and Windows. As library dependencies (like kotlinx-coroutines) have also been adding linuxArm64 support, I'm also now able to add this target myself. So that'd be great if you could include it in multiplatform-paging. Thanks!

@veyndan
Copy link
Collaborator

veyndan commented Sep 25, 2023

Excited to see this as a part of your library! I just released 3.3.0-alpha02-0.4.0 which tracks 3.3.0-alpha02 and adds support for linuxArm64. Please let me know if you face any issues with it!

@veyndan veyndan closed this Sep 25, 2023
@jeffdgr8
Copy link
Author

Great, I updated and tests are all passing with my paging extension. Thanks for adding the linuxArm64 target.

@jeffdgr8
Copy link
Author

@veyndan I just ran across this conversation from one of those tabs I've left open for months. 😅 Thought I'd drop a link to my paging extensions for my KMP database library, now that it's been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants