Add support for JDK 21+ #1712
Add support for JDK 21+ #1712
Conversation
.github/workflows/build.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| windows-latest, | |||
| ubuntu-latest | |||
| ] | |||
| java-version: [17, 18] | |||
| java-version: [17, 18, 22] | |||
There was a problem hiding this comment.
Consider:
| java-version: [17, 18, 22] | |
| java-version: [17, 21, 22] |
So that it definitely works on LTS 21. Testing only on 22 could result in the library using 22-only features that are not in 21.
build.gradle
Outdated
| // Enabled dynamic agent loading (ByteBuddy) for JDK 21+ https://openjdk.org/jeps/451 | ||
| jvmArgs '-XX:+EnableDynamicAgentLoading' |
There was a problem hiding this comment.
Do consumers need to add this too?
(i.e. should this be part of the plugin, behind a version check: JavaVersion.current() or Test.javaVersion)
There was a problem hiding this comment.
good point let me update this 👍🏽
There was a problem hiding this comment.
What do you think about making it part of the Paparazzi Gradle Plugin? If I added Paparazzi to a project running CI on 22, would I need to add this line too?
There was a problem hiding this comment.
yep, I added this in my latest commit
There was a problem hiding this comment.
note: if you have it in plugin, then is it still necessary in root build.gradle?
|
verified gradle java sdk and compile java sdk to 22 builds successfully. |
geoff-powell
requested review from
nak5ive,
BrianGardnerAtl,
gamepro65 and
jrodbx
geoff-powell
force-pushed
the
gpowell/jdk-versions
branch
from
79ddb14
to
a162c95
Compare
geoff-powell
force-pushed
the
gpowell/jdk-versions
branch
2 times, most recently
from
f6b6214
to
4797778
Compare
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Outdated
Show resolved
Hide resolved
geoff-powell
force-pushed
the
gpowell/jdk-versions
branch
from
4797778
to
e735b14
Compare
closed #565