-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DE-6596: VU meter component #15
Conversation
21d3a9a
to
dd31ffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice VU meter :) just had some comments and questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great in storybook! :)
Few comments to look into.
Co-authored-by: Thasso Griebel <[email protected]>
b28dff7
to
44bba76
Compare
Co-authored-by: doubeka <[email protected]>
@thasso Thanks for pushing this forward! :) Fun factPS: One thing you may have noticed is that instead of taking the average of the amplitudes/volumes I decided to split the frequencies into a couple of bins, average each bin and take the maximum of that. This is because if I take the average over all frequencies even loud audio produces max only cca 50% amplitude/volume in a normal audio track for a movie or something (it doesn't happen that all frequencies would be at max amplitued/volume, not even close).
So that's my hack on how to make sure the volume bar goes up to the top when I as a human ear hear loud audio 😄. I think it works pretty well at this point, so I would not like to mess with it more inside this PR, but it's a fun exercise to think about how to work with the volume. |
I adressed the issues and we want to merge it now.
It's a meter that shows the current levels of volume (left and right channels separately).