DE-6746: Add a GH workflow to publish a release #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingerartur
force-pushed
the
feat/DE-6746-workflow
branch
2 times, most recently
from
002c1bb to
8ef14d1
Compare
fingerartur
changed the title
fingerartur
force-pushed
the
feat/DE-6746-workflow
branch
from
73e6cc7 to
2dd49bf
Compare
Add a GitHub workflow which publishes the package to NPM and API docs to `https://players.castlabs.com/react-dom/<version>/docs/` when a new Release is manually created on GitHub. The version is taken from the tag created with the Release on GitHub. Beta versions are also supported. Also clean up the readme and the docs homepage.
fingerartur
force-pushed
the
feat/DE-6746-workflow
branch
from
2dd49bf to
f575c8f
Compare
thasso
requested changes
Nov 28, 2023
This NPM feature requires upgrade to at least node 18, but GitHub actions don't support node 18 so I'm upgrading to 20.
|
@thasso I've also added provenance verification and switched to a granular NPM token. Provenance works, I've tested it with a beta NPM release, just an interesting note on that topic: it needs Node.js version 20 (actually version 18 would be enough, but GitHub actions somehow don't support it, at least not explicitly, so version 20 it is 😄). |
thasso
requested changes
Nov 28, 2023
thasso
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm adding a GitHub workflow to publish a new version to NPM and deploy API docs for that version to https://players.castlabs.com/react-dom/x.x.x/docs/. It gets triggered when we create a new Release in GitHub (when creating the release, select "Create new tag" and specify the target version).
Beta versions are also supported and they will be published accordingly to a NPM beta channel (non-main channel).