Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-7720: Fix touch interaction #45

Merged
merged 3 commits into from
Sep 9, 2024
Merged

DE-7720: Fix touch interaction #45

merged 3 commits into from
Sep 9, 2024

Conversation

fingerartur
Copy link
Contributor

Here I'm fixing problems with touch interaction, which were mostly affecting Android mobile devices.

Some components react only to mouse
and not to touch events. This makes
the UI hard to use touch-based platforms
(e.g. Android phone).

Add support for touch interaction
by listening to touch events.
@fingerartur fingerartur requested a review from doubeka September 4, 2024 11:07
Copy link

@doubeka doubeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tested briefly on iPadOS 17 and iOS 17.5 Safari and looks fine!
Lets look together to setMuted issue before we merge

package.json Outdated Show resolved Hide resolved
@fingerartur fingerartur requested a review from doubeka September 6, 2024 11:12
@doubeka
Copy link

doubeka commented Sep 9, 2024

Alright, let's not forget to update the version of @castlabs/prestoplay" once we release a new version with a fix
https://castlabs.atlassian.net/browse/DE-7261. So lets create a ticket for it.

@fingerartur fingerartur merged commit c3c354d into main Sep 9, 2024
1 check passed
@fingerartur fingerartur deleted the fix/DE-7220-mobile-ui branch September 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants