Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ theme を index.tsx から re-export するように #18

Merged
merged 1 commit into from
May 24, 2024

Conversation

SSlime-s
Copy link
Member

一瞬系

@SSlime-s SSlime-s requested review from ras0q and toshi-pono May 24, 2024 05:43
@SSlime-s SSlime-s self-assigned this May 24, 2024
@SSlime-s SSlime-s force-pushed the SSlime/collect-theme branch from 0c59e7c to 83dbb76 Compare May 24, 2024 05:44
Copy link

cloudflare-workers-and-pages bot commented May 24, 2024

Deploying nascalay-v2-preview with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83dbb76
Status: ✅  Deploy successful!
Preview URL: https://e57e9459.nascalay-v2-preview.pages.dev
Branch Preview URL: https://sslime-collect-theme.nascalay-v2-preview.pages.dev

View logs

Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これが一般によく使われる方法ならapprove

@SSlime-s
Copy link
Member Author

Barrel File って言うらしい
https://typescript-jp.gitbook.io/deep-dive/main-1/barrel

Biome だとできないけど、ほんとは ESLint のルールとかで、index.tsx 以外の import を阻害すると good

@SSlime-s SSlime-s merged commit bc4e9be into main May 24, 2024
4 checks passed
@SSlime-s SSlime-s deleted the SSlime/collect-theme branch May 24, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants