Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax postmaster checks #51 #52

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

bwalkerl
Copy link
Contributor

Relaxed postmaster checks and added checking based on user email domains.

A couple of notes:

  • The check on user domains is limited to the 5 most common for the mx lookup, but did we also want an additional check on gmail domains outside the top 5? If so should there be a minimum?
  • Both tables in this check are rendered very roughly. Ideally they should use a proper template.

Closes #51

@bwalkerl bwalkerl force-pushed the 51-relax-postmaster branch 3 times, most recently from a268d28 to 5cc428e Compare October 17, 2024 07:28
@bwalkerl bwalkerl force-pushed the 51-relax-postmaster branch 2 times, most recently from 9214a2e to 82c1763 Compare October 17, 2024 23:54
@brendanheywood brendanheywood merged commit 110170d into MOODLE_39_STABLE Oct 22, 2024
30 checks passed
@brendanheywood brendanheywood deleted the 51-relax-postmaster branch October 22, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax the security warning for gmail
2 participants