Initial improvements for bounce handling reporting #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwalkerl
commented
Nov 14, 2024
| protected function get_default_tables(): array { | ||
| return [ | ||
| 'user_preferences', | ||
| 'user_preferences_send', |
There was a problem hiding this comment.
Does this need to be a table that exists? I couldn't find an easy way to join with own table and have a separate alias without a second table listed.
There was a problem hiding this comment.
I'm not sure, this is the kind of thing I'd ask in the dev chat
|
|
||
| $this->set_main_table('user_preferences', $entitymainalias); | ||
| $this->add_entity($entitymain); | ||
| $this->add_base_condition_simple("{$entitymainalias}.name", 'email_bounce_count'); |
There was a problem hiding this comment.
Ideally I wanted to add this condition to the entity but couldn't find a way.
bwalkerl
force-pushed
the
dev-bounce-handling
branch
2 times, most recently
from
479503e
to
8cb48f7
Compare
bwalkerl
force-pushed
the
dev-bounce-handling
branch
from
8cb48f7
to
a909a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60