Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui experience and response latency #91

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

crypto0627
Copy link
Contributor

@crypto0627 crypto0627 commented Nov 29, 2023

PULL REQUEST

Before

說明 (Description)

Solve bdk ui selectInput latency. use asynchronous to resolve the problem!

In src/ui/services/commandContext CommandText class getCommandContext stuck the UI render progress.

相關問題 (Linked Issues)

  • Ui SelectInput Lag

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: Linux 5.15.133.1-microsoft-standard-WSL2 x86_64
  • NodeJS Version:v18.18.2
  • NPM Version:9.8.1
  • Docker Version:24.0.7

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單,並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)

@crypto0627 crypto0627 changed the title Fix/UI lag fix: UI lag Nov 29, 2023
@kidneyweakx kidneyweakx changed the title fix: UI lag fix: ui experience and response latency Nov 30, 2023
@kidneyweakx kidneyweakx changed the base branch from master to 2.0.5 November 30, 2023 01:52
Copy link
Collaborator

@kidneyweakx kidneyweakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should change commit message from temp to fix

@kidneyweakx
Copy link
Collaborator

LGTM!

@kidneyweakx kidneyweakx merged commit 4479aa9 into cathayddt:2.0.5 Dec 1, 2023
1 check passed
@kidneyweakx kidneyweakx mentioned this pull request Dec 5, 2023
14 tasks
Pianochicken pushed a commit that referenced this pull request Dec 5, 2023
* feat: bdk ui redesign (#89)

* feat: bdk ui redesign

* fix: bdk ui layout

* chore: update node version to 18.18 (#90)

* chore: update node version to 18.18

* fix: test runtime error

* fix: ui selectInput delay (#91)

refactor commandContext class functions to asynchronous, solve the process stuck issue.

* feat: lazy loading in command change (#92)

* feat: option lazy loading

* fix: debounce in select input

---------

Co-authored-by: kidneyweak <[email protected]>

* fix: update docker logs component (#93)

* chore: npm packages update (#94)

* chore: update 2.0.5 and packages

* chore: update 2.0.5 CHANGELOG.md

* fix: eslint error for newer ericlint

---------

Co-authored-by: 郭來鴻 <[email protected]>
Co-authored-by: JakeKuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants