Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CauliViewController with sections #178

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pstued
Copy link
Member

@pstued pstued commented Mar 11, 2019

  • write ticket
  • self review
  • update commit message

@pstued pstued changed the title update me Improve CauliViewController with sections Mar 11, 2019
@pstued
Copy link
Member Author

pstued commented Mar 14, 2021

A while ago I started to introduce more structure into the CauliViewController with an enum separating intercepting and displaying florets. What do you think @brototyp, is this an idea worth to continue?

@brototyp
Copy link
Member

Hm, interesting. The other day I actually thought about merging both of them together. There is one downside of separating both: What if a floret is both. An intercepting and a displaying floret? For example the MapRemoteFloret. It does intercept all requests and at the same time it displays a settings page where you can enable and disable all mappings.

I am not sure yet, but we could change it to actually just have a single array of florets. In there all displaying florets have a disclosure triangle and all intercepting florets have a switch.

Do you think that would make things more clear? Easier? Or actually rather more irritating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants