Added FilecachedInputOutputStream #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| init(fileCache: URL) { | ||
| writableOutputStream = OutputStream(url: fileCache, append: true) | ||
| writableOutputStream?.open() | ||
| readableInputStream = InputStream(url: fileCache)! |
There was a problem hiding this comment.
| Force unwrapping should be avoided. |
There was a problem hiding this comment.
how about adding a swiftlint:next:disable force_unwrapping ?
There was a problem hiding this comment.
Yeah! What do you think about this?
Suggested change
| readableInputStream = InputStream(url: fileCache)! | |
| readableInputStream = InputStream(url: fileCache)! // swiftlint:disable:this force_unwrapping |
| writableOutputStream?.open() | ||
| readableInputStream = InputStream(url: fileCache)! | ||
| cacheFile = fileCache | ||
| super.init(url: fileCache)! |
There was a problem hiding this comment.
| Force unwrapping should be avoided. |
There was a problem hiding this comment.
Same here 😊
Suggested change
| super.init(url: fileCache)! | |
| super.init(url: fileCache)! // swiftlint:disable:this force_unwrapping |
Example CHANGELOG entry* **feature/improvement/bugfix** Added FilecachedInputOutputStream
[#issue_number](https://github.com/cauliframework/cauli/issues/issue_number) by @brototyp Trivial PR?If you think your PR is trivial and neither a CHANGELOG entry nor a README update is necessary, you can add a Generated by 🚫 Danger |
pstued
approved these changes
Oct 10, 2019
| init(fileCache: URL) { | ||
| writableOutputStream = OutputStream(url: fileCache, append: true) | ||
| writableOutputStream?.open() | ||
| readableInputStream = InputStream(url: fileCache)! |
There was a problem hiding this comment.
how about adding a swiftlint:next:disable force_unwrapping ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a FilecachedInputOutputStreamSpec. This is a Stream that can written to and read from. This will be used, so when data is received from the server, we can pass the data one layer up while having a file everything is written to.