Feature/signed contingent inputs #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeck88
force-pushed
the
feature/mixed-transactions
branch
from
0037f82 to
71cd422
Compare
cbeck88
force-pushed
the
feature/signed-contingent-inputs
branch
2 times, most recently
from
4705a1f to
892f742
Compare
* add workflow-dispatch placeholdes so we can run on other non-default branches * add delete dispatch
…ecoinfoundation#1858) * initial work on consensus config api endpoint * add governors signature to config * expose more configuration params * minor edits * try and fix go build * Update consensus/api/proto/consensus_config.proto Co-authored-by: Remoun Metyas <[email protected]> * Update consensus/api/src/conversions.rs Co-authored-by: Remoun Metyas <[email protected]> Co-authored-by: Remoun Metyas <[email protected]>
* allow transactions with "mixed" token types these are introduced at block version 3 the token type of every pseudo output and real output must be listed in `pseudo_output_token_ids` and `output_token_ids` in the `SignatureRctBulletproofs` object * Update mobilecoind-json/src/data_types.rs Co-authored-by: Remoun Metyas <[email protected]> * Update mobilecoind-json/src/data_types.rs Co-authored-by: Remoun Metyas <[email protected]> * Update mobilecoind-json/src/data_types.rs Co-authored-by: Remoun Metyas <[email protected]> * cargo fmt * fix mobilecoind-json conversions * review comments * fixups * add more test coverage on mixed transactions * add transaction builder support for mixed transactions, and tests * fix the world * don't, at this time, make mobilecoind start writing 0 value change this should happen at the time of adding RTH support to mobilecoind * eran comments * Update transaction/core/src/ring_signature/error.rs Co-authored-by: Remoun Metyas <[email protected]> * more review comments * Make a wrapper for u64 which serializes to json as string this addresses review comments * missing copyright * more review comments * more uses of `Amount::new` * cleanup in transaction builder around Amount * cleanup tx prefix around Amount * cleanup input secret and output secret around Amount * Update transaction/core/src/ring_signature/rct_bulletproofs.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/memo_builder/rth_memo_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: Remoun Metyas <[email protected]> * Update consensus/service/src/validators.rs Co-authored-by: Remoun Metyas <[email protected]> * fix build * JsonTokenId -> JsonU64, and code shortening in lots of places * more JsonU64 * Update transaction/core/src/ring_signature/generator_cache.rs Co-authored-by: Remoun Metyas <[email protected]> * replace assert with error * Make `TransactionBuilder::new(` take the fee `Amount` this cleans up the constructor * fix build * fix clippy * replace assert with error in another place * fix a variable name, per review comments * add a code comment about balance proofing after this mixed transactions stuff * fixup code comment * Update transaction/core/src/blockchain/block_version.rs Co-authored-by: sugargoat <[email protected]> * Update transaction/core/src/ring_signature/rct_bulletproofs.rs Co-authored-by: sugargoat <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: sugargoat <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: sugargoat <[email protected]> * Update transaction/std/src/transaction_builder.rs Co-authored-by: sugargoat <[email protected]> * Update transaction/core/src/tx_error.rs Co-authored-by: sugargoat <[email protected]> * Update transaction/core/src/ring_signature/rct_bulletproofs.rs Co-authored-by: sugargoat <[email protected]> * improve code comment * add code comments in external.proto * add github issue references in sources * cargo format of code comments Co-authored-by: Remoun Metyas <[email protected]> Co-authored-by: sugargoat <[email protected]>
This will be useful for testing the signed contingent inputs
cbeck88
force-pushed
the
feature/signed-contingent-inputs
branch
from
892f742 to
18f1453
Compare
cbeck88
pushed a commit
that referenced
this pull request
Oct 26, 2023
mobilecoinfoundation#2062) * added proper testing for sorted outputs for BlockVersion version 3 and higher * linting fix * linting fix #2 * linting fix #3 * linting fix #4 * linting fix #5 * removed mod crate Co-authored-by: Eugene Rata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second step of MCIP mobilecoinfoundation#31, which enables a secure atomic swap on chain