[PhotoBooth] mode with image persistence along side audio file. Also, streaming capabilities, setup script, readme updates, and narrator prompt update #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncreased complex descriptors. (#2)
* spacebar * trunk * cleanup
…se. Also, small README format refactor. (#5)
… native os cp command via the script.
* [Image] file saved along side the corresponding audio file (#6) * [Image] file saved along side the corresponding audio file. * [shutil] used thanks to trunk calling out security implication of the native os cp command via the script. * [README] small update to streaming section to mention image file is not saved either. * [README] small setup.sh wording refactor. * [Fix] narrator when streaming is enabled regardign image save logic
* [Image] file saved along side the corresponding audio file (#6) * [Image] file saved along side the corresponding audio file. * [shutil] used thanks to trunk calling out security implication of the native os cp command via the script. * [README] small update to streaming section to mention image file is not saved either. * [README] small setup.sh wording refactor. * [Fix] narrator when streaming is enabled regarding image save logic (#8) * [Fix] narrator when streaming is enabled regardign image save logic * [Fix] imagesave. * cleanup
|
This looks great! thank you! Will take a look tonight or tomorrow |
eroncanc
reviewed
Dec 9, 2023
|
|
||
| Alternative to running the [Setup](#setup) commands above individually, one can use the `setup.sh` script to facilitate getting the two required shell envs ready to rock. | ||
|
|
||
| _Note: will have to run `source source venv/bin/activate` afterwards to activate the virtual env._ |
|
very nice contribution! |
|
Great PR! Let's see it merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
setup.shscript to facilitate getting the two shell envs setup to runcapture.pyandnarrator.py.Also, updated README withsetup.shusage info. From [Setup] script and readme updated #32.env.examplefile and README updates. Based on https://github.com/cbh123/narrator/pull/30/files.