-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake option to use a system installed sc #306
CMake option to use a system installed sc #306
Conversation
Whoopsie, I did not see the other compile option and merged them now. |
Thanks so much! We're in the middle of merging a few CMake updates in libsc and will then align p4est to work the same way as much as possible. Let's keep an eye on these merges to make sure your code works cleanly with those. |
This PR should be rebased on |
Thanks again! I'd be hoping that this runs fine on top of the latest develop branch. |
@cburstedde Done, at least locally all tests pass with the libsc shipped by p4est and also with a locally installed libsc (: |
Thanks, and welcome to the list of developers! :) As a follow-up, please consider #312 and let us know if that affects this update. |
Ah, btw., if (not necessarily for this one, but in the future) you might add a line to doc/release_notes.txt. |
Add CMake option to use a system installed SC
Proposed changes:
For our new t8code CMake CI we need the option to build p4est with a system installed SC version.
This option already exists in p4ests autotools build system but does not exist in the CMake build system.
This PR adds this option. The standard behavior of p4ests CMake build system is not altered since the standard policy is to use the SC which ships with p4est.