feat(ui): Adding slack handle to corp group info (datahub-project#5645)

cccs-tom · Aug 15, 2022 · be22455 · be22455
1 parent b496994
commit be22455
Show file tree

Hide file tree

Showing 13 changed files with 43 additions and 10 deletions.
diff --git a/.../java/com/linkedin/datahub/graphql/types/corpgroup/mappers/CorpGroupPropertiesMapper.java b/.../java/com/linkedin/datahub/graphql/types/corpgroup/mappers/CorpGroupPropertiesMapper.java
@@ -1,5 +1,6 @@
 package com.linkedin.datahub.graphql.types.corpgroup.mappers;
 
+import com.linkedin.data.template.GetMode;
 import com.linkedin.datahub.graphql.generated.CorpGroupProperties;
 import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
 
@@ -24,6 +25,7 @@ public CorpGroupProperties apply(@Nonnull final com.linkedin.identity.CorpGroupI
     result.setEmail(info.getEmail());
     result.setDescription(info.getDescription());
     result.setDisplayName(info.getDisplayName());
+    result.setSlack(info.getSlack(GetMode.DEFAULT));
     return result;
   }
 }
diff --git a/datahub-graphql-core/src/main/resources/entity.graphql b/datahub-graphql-core/src/main/resources/entity.graphql
@@ -3224,6 +3224,11 @@ type CorpGroupProperties {
     email of this group
     """
     email: String
+
+    """
+    Slack handle for the group
+    """
+    slack: String
 }
 
 """

diff --git a/datahub-web-react/src/app/entity/group/GroupProfile.tsx b/datahub-web-react/src/app/entity/group/GroupProfile.tsx
@@ -103,7 +103,7 @@ export default function GroupProfile() {
             data?.corpGroup?.info?.displayName ||
             undefined,
         email: data?.corpGroup?.editableProperties?.email || data?.corpGroup?.properties?.email || undefined,
-        slack: data?.corpGroup?.editableProperties?.slack || undefined,
+        slack: data?.corpGroup?.editableProperties?.slack || data?.corpGroup?.properties?.slack || undefined,
         aboutText:
             data?.corpGroup?.editableProperties?.description || data?.corpGroup?.properties?.description || undefined,
         groupMemberRelationships: groupMemberRelationships as EntityRelationshipsResult,

diff --git a/datahub-web-react/src/graphql/group.graphql b/datahub-web-react/src/graphql/group.graphql
@@ -21,6 +21,7 @@ query getGroup($urn: String!, $membersCount: Int!) {
             displayName
             description
             email
+            slack
         }
         ownership {
             ...ownershipFields
@@ -217,4 +218,4 @@ mutation updateCorpGroupProperties($urn: String!, $input: CorpGroupUpdateInput!)
     updateCorpGroupProperties(urn: $urn, input: $input) {
         urn
     }
-}
+}
diff --git a/metadata-ingestion/examples/mce_files/bootstrap_mce.json b/metadata-ingestion/examples/mce_files/bootstrap_mce.json
@@ -83,7 +83,8 @@
               "email": "[email protected]",
               "admins": ["urn:li:corpuser:jdoe", "urn:li:corpuser:datahub"],
               "members": ["urn:li:corpuser:jdoe", "urn:li:corpuser:datahub"],
-              "groups": []
+              "groups": [],
+              "slack":  "bfoo-squad"
             }
           }
         ]

diff --git a/metadata-models/src/main/pegasus/com/linkedin/identity/CorpGroupInfo.pdl b/metadata-models/src/main/pegasus/com/linkedin/identity/CorpGroupInfo.pdl
@@ -73,4 +73,8 @@ record CorpGroupInfo {
   }
   description: optional string
 
+  /**
+   * Slack channel for the group
+   */
+  slack: optional string
 }
diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
@@ -380,7 +380,7 @@
             }, {
               "name" : "message",
               "type" : "string",
-              "doc" : "Additional message to keep track of in the event",
+              "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
               "optional" : true
             } ]
           },
@@ -1891,6 +1891,11 @@
       "Searchable" : {
         "fieldType" : "TEXT_PARTIAL"
       }
+    }, {
+      "name" : "slack",
+      "type" : "string",
+      "doc" : "Slack channel for the group",
+      "optional" : true
     } ],
     "Aspect" : {
       "EntityUrns" : [ "com.linkedin.common.CorpGroupUrn" ],

diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json
@@ -139,7 +139,7 @@
             }, {
               "name" : "message",
               "type" : "string",
-              "doc" : "Additional message to keep track of in the event",
+              "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
               "optional" : true
             } ]
           },
@@ -2139,6 +2139,11 @@
                     "Searchable" : {
                       "fieldType" : "TEXT_PARTIAL"
                     }
+                  }, {
+                    "name" : "slack",
+                    "type" : "string",
+                    "doc" : "Slack channel for the group",
+                    "optional" : true
                   } ],
                   "Aspect" : {
                     "EntityUrns" : [ "com.linkedin.common.CorpGroupUrn" ],

diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entitiesV2.snapshot.json
@@ -32,7 +32,7 @@
     }, {
       "name" : "message",
       "type" : "string",
-      "doc" : "Additional message to keep track of in the event",
+      "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
       "optional" : true
     } ]
   }, "com.linkedin.common.Time", "com.linkedin.common.Urn", {

diff --git a/...ervice/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json b/...ervice/restli-api/src/main/snapshot/com.linkedin.entity.entitiesVersionedV2.snapshot.json
@@ -32,7 +32,7 @@
     }, {
       "name" : "message",
       "type" : "string",
-      "doc" : "Additional message to keep track of in the event",
+      "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
       "optional" : true
     } ]
   }, "com.linkedin.common.Time", "com.linkedin.common.Urn", {

diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json
@@ -139,7 +139,7 @@
             }, {
               "name" : "message",
               "type" : "string",
-              "doc" : "Additional message to keep track of in the event",
+              "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
               "optional" : true
             } ]
           },
@@ -1642,6 +1642,11 @@
       "Searchable" : {
         "fieldType" : "TEXT_PARTIAL"
       }
+    }, {
+      "name" : "slack",
+      "type" : "string",
+      "doc" : "Slack channel for the group",
+      "optional" : true
     } ],
     "Aspect" : {
       "EntityUrns" : [ "com.linkedin.common.CorpGroupUrn" ],

diff --git a/...ata-service/restli-api/src/main/snapshot/com.linkedin.lineage.relationships.snapshot.json b/...ata-service/restli-api/src/main/snapshot/com.linkedin.lineage.relationships.snapshot.json
@@ -32,7 +32,7 @@
     }, {
       "name" : "message",
       "type" : "string",
-      "doc" : "Additional message to keep track of in the event",
+      "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
       "optional" : true
     } ]
   }, {

diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json
@@ -139,7 +139,7 @@
             }, {
               "name" : "message",
               "type" : "string",
-              "doc" : "Additional message to keep track of in the event",
+              "doc" : "Additional context around how DataHub was informed of the particular change. For example: was the change created by an automated process, or manually.",
               "optional" : true
             } ]
           },
@@ -2133,6 +2133,11 @@
                     "Searchable" : {
                       "fieldType" : "TEXT_PARTIAL"
                     }
+                  }, {
+                    "name" : "slack",
+                    "type" : "string",
+                    "doc" : "Slack channel for the group",
+                    "optional" : true
                   } ],
                   "Aspect" : {
                     "EntityUrns" : [ "com.linkedin.common.CorpGroupUrn" ],