Skip to content

Commit

Permalink
Fixed panic crash, subprocess hang. (#27)
Browse files Browse the repository at this point in the history
  • Loading branch information
cceremuga authored Nov 19, 2022
1 parent 2465808 commit e7e5369
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ This project is the next-generation successor to [PyPacket](https://gihub.com/cc

## Release Notes

* 11/19/2022 ([1.0.3 release](https://github.com/cceremuga/ionosphere/releases/tag/v1.0.3))
* Removed type logging to temporarily work around a panic/subprocess hang.
* 11/15/2022 ([1.0.2 release](https://github.com/cceremuga/ionosphere/releases/tag/v1.0.2))
* Fixed [an issue](https://github.com/cceremuga/ionosphere/issues/18) with config-supplied args for `rtl_fm` and `multimon-sg`.
* Logging is now more verbose, including error output during the startup sequence for the underlying `rtl_fm`, `multimon-ng` processes.
Expand Down
12 changes: 1 addition & 11 deletions framework/marshaler/marshaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,9 @@ func Unmarshal(raw string) (*aprs.Packet, error) {

// Converts a packet to its reusable output format.
func ToLogFormat(p *aprs.Packet) string {
defer func() {
if err := recover(); err != nil {
log.Error(err, fmt.Sprintf(" (%s)", p.Raw))
}
}()

// Panic recovery above due to https://github.com/pd0mz/go-aprs/issues/5
packetType := p.Payload.Type()

return fmt.Sprintf("%s -> %s [%s] (%f, %f) %s",
return fmt.Sprintf("%s -> %s (%f, %f) %s",
p.Src.Call,
p.Dst.Call,
packetTypeName(packetType),
p.Position.Latitude,
p.Position.Longitude,
p.Comment,
Expand Down

0 comments on commit e7e5369

Please sign in to comment.