Skip to content

Commit

Permalink
conda: ensure that custom_bin is lowercase
Browse files Browse the repository at this point in the history 
[skip ci]
  • Loading branch information
@bkpoon
bkpoon committed Sep 27, 2023
1 parent 5703140 commit 877295b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libtbx/auto_build/conda_build/create_custom_bin.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def copy_bin(prefix, custom_bin, packages=[]):

namespace = parser.parse_args()

copy_bin(namespace.prefix, namespace.custom_bin, namespace.packages)
copy_bin(namespace.prefix, namespace.custom_bin.lower(), namespace.packages)

# =============================================================================
# end

2 comments on commit 877295b

@ndevenish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time tests were run was also failing with python 3 syntax

Compiling ./libtbx/auto_build/conda_build/create_custom_bin.py ...
  File "./libtbx/auto_build/conda_build/create_custom_bin.py", line 56
    print(f'{new_prefix/bin_name} already exists, skipping')

(investigating because our mirror only updates when cctbx tests pass, which meant that none of serialtbx made it through)

@bkpoon
Copy link
Member Author

@bkpoon bkpoon commented on 877295b Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let me know if the error persists. The script should work with Python 3.7 and later.

Please sign in to comment.