bootstrap.py: add XFEL-specific defaults #807
Open
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just something I was playing with. There are two things to consider here:
options.pythonis equal to the default (currently'27') I don't know if there is a clean way to decide whether that value was explicitly supplied by the user. We could setdefault=Noneand catch that value and set it to the real default, but then the parser can't tell the user what the default is. However in this case I think we can reasonably assume that no user is actually requesting 27, so the XFEL builder catches that value and resets it to 39.I think these changes would be nice, but they're not urgent, so feel free to consider this a conversation starter on builder-specific bootstrap defaults :)