Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: first implementation of cdevents-sdk from json-schema #8
feat: first implementation of cdevents-sdk from json-schema #8
Changes from 32 commits
36ec9e0
4353836
82bfe86
ff776e4
a25f150
f727547
085b6ed
79551ca
1428d48
479cb5d
3a51cb9
e738b7f
59210a6
b63b9d6
c286321
8d5586f
ba31fb9
7efb1c4
449948d
2a0d732
865ebf2
de04bb2
e0d9e94
184e70f
d952752
ad8f665
97b6a51
799cd26
a7ca3cc
41480b1
25e2dcc
9bc4e33
7ead28c
6c72ab9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used lint here in the matrix because i wanted to differentiate with next coming tests ci. Now that you renamed it to task it is not really clear what it is! If it is the linter_ci or the tests_ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply call this workflow
ci
(andci.yml
for the filename, github workflow often use this name, and the extension.yml
, like what is generated by github and other framework).We can discuss this point into a next PR. So I'll revert my change.