feat: allow periods (".") in alarm names (#593)

FIFO queues require a suffix of ".fifo" and thus do not work without alarm name overrides. This is tedious. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_ Co-authored-by: Roy Howie <[email protected]>
cdklabs · Nov 12, 2024 · 3ef0747 · 3ef0747
1 parent cf8640d
commit 3ef0747
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/dashboard/MonitoringNamingStrategy.ts b/lib/dashboard/MonitoringNamingStrategy.ts
@@ -62,7 +62,7 @@ export class MonitoringNamingStrategy {
   static isAlarmFriendly(str: string) {
     // we do not know the exact pattern yet, but this is a safe approximation
     // also, tokens are not allowed in alarm names
-    return str && !Token.isUnresolved(str) && /^[a-zA-Z0-9\-_]+$/.test(str);
+    return str && !Token.isUnresolved(str) && /^[a-zA-Z0-9\-_\.]+$/.test(str);
   }
 
   private getFallbackAlarmFriendlyName() {

diff --git a/test/dashboard/MonitoringNamingStrategy.test.ts b/test/dashboard/MonitoringNamingStrategy.test.ts
@@ -21,7 +21,7 @@ test("string with comma is not alarm friendly", () => {
 
 test("this string is alarm friendly", () => {
   expect(
-    MonitoringNamingStrategy.isAlarmFriendly("This_is__Valid-Alarm-Name"),
+    MonitoringNamingStrategy.isAlarmFriendly("This_is__Valid-Alarm.Name"),
   ).toBeTruthy();
 });