fix(lambda): fix iterator age dedupe #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our team has tiered alarms on the max iterator age of events going to a Lambda function so that we get higher severity tickets for higher iterator ages which indicates worse backups in processing. However, these are not currently deduping into the same ticket which I root caused to the `alarmDedupeStringSuffix` being missing on the `addIteratorMaxAgeAlarm` which the Lambda monitoring uses. This PR fixes this.
echeung-amzn
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team has tiered alarms on the max iterator age of events going to a Lambda function so that we get higher severity tickets for higher iterator ages which indicates worse backups in processing.
However, these are not currently deduping into the same ticket which I root caused to the
alarmDedupeStringSuffixbeing missing on theaddIteratorMaxAgeAlarmwhich the Lambda monitoring uses.This PR fixes this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license