fix: Add sampleCountMetricId to CustomAlarmThreshold #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarni
changed the title
bamarni
changed the title
This provides support for `minSampleCountToEvaluateDatapoint` when using eg. `ErrorAlarmFactory`. See cdklabs#466 where the feature was introduced.
echeung-amzn
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides support for
minSampleCountToEvaluateDatapointwhen using eg.ErrorAlarmFactory. Without this change and with aMathExpressioncontaining multiple metrics, one would get the following error:However
sampleCountMetricIdis currently not available inCustomAlarmThreshold.See #466 for original change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license