feat!: v9 breaking changes #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeung-amzn
added
the
do-not-merge
giantcow
reviewed
Nov 13, 2024
test/monitoring/aws-secretsmanager/__snapshots__/SecretsManagerSecretMonitoring.test.ts.snap
Outdated
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Extracting from #594 since it wasn't really relevant. The problem with the types being incompatible has been long resolved. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
echeung-amzn
force-pushed
the
breaking
branch
from
5ad4bbe to
944b537
Compare
This allows us to consistently resolve stack information like region and account.
The upstream MathExpression supports this now.
This unfortunately drops the guard for non-serverless DatabaseClusters for Aurora monitoring since the constructs are now nearly indistinguishable based on their properties.
echeung-amzn
force-pushed
the
breaking
branch
from
944b537 to
6cdb65a
Compare
giantcow
approved these changes
Nov 13, 2024
|
|
||
| expect.addSnapshotSerializer({ | ||
| test: (val) => | ||
| val && Object.prototype.hasOwnProperty.call(val, "LatestNodeRuntimeMap"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE AS-IS; I need to merge this non-squashed to retain a sensible commit history.
This PR includes some breaking changes to the API and minimum
aws-cdk-libpeer dependency to unblock usage of newer features.Refer to the individual commits for more details.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license