Prometheus metrics #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arno
suggested changes
Aug 30, 2017
There was a problem hiding this comment.
It seems the vendor files were directly copied. Can you use Glide to manage them instead (see https://glide.sh and the glide.yaml file)?
You also need to update the documentation files in doc/ to describe the new PromListen parameter (it may be renamed prom_listen to match the other parameters?).
| @@ -26,12 +26,17 @@ import ( | |||
|
|
|||
| "github.com/op/go-logging" | |||
| "gopkg.in/yaml.v2" | |||
|
|
|||
| "github.com/prometheus/client_golang/prometheus" | |||
| "github.com/prometheus/client_golang/prometheus/promhttp" | |||
There was a problem hiding this comment.
Move these imports below the go-logging import.
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/client_golang/prometheus/promhttp" | ||
| "net/http" |
There was a problem hiding this comment.
Move this import with the other standard imports.
fihuer
force-pushed
the
prometheus_metrics
branch
from
710519c
to
3167b79
Compare
arno
force-pushed
the
prometheus_metrics
branch
3 times, most recently
from
7e642a4
to
5896abc
Compare
cyrilst
force-pushed
the
master
branch
6 times, most recently
from
7ca0082
to
6d3fa42
Compare
cyrilst
force-pushed
the
master
branch
2 times, most recently
from
dd3157a
to
ddf56a4
Compare
cyrilst
force-pushed
the
master
branch
7 times, most recently
from
64c8f1a
to
9931db0
Compare
cyrilst
force-pushed
the
master
branch
5 times, most recently
from
fb62b12
to
a6f0cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1