Merge pull request newrelic#1393 from NodeJS-agent/psvet/fix-hapi-pre

NODE-1713 Fix Hapi 'pre' config wrapping
ceastman-ibm · Mar 23, 2018 · 24d3f1c · 24d3f1c
2 parents 6b45283 + 7837b6e
commit 24d3f1c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/lib/instrumentation/hapi.js b/lib/instrumentation/hapi.js
@@ -146,6 +146,10 @@ function wrapPreHandlers(shim, container, path) {
       return _wrapPreHandler(handler)
     })
   }
+  // The 'pre' option also allows strings pointing to methods registered via
+  // server.method() (ie: 'methodName(args)'). For the most part, these should
+  // be simple utility functions, but may be something we want to wrap in the future.
+  return container
 
   function _wrapPreHandler(handler) {
     return shim.recordMiddleware(

diff --git a/test/versioned/hapi/hapi-pre-17/router-v16.tap.js b/test/versioned/hapi/hapi-pre-17/router-v16.tap.js
@@ -90,6 +90,11 @@ tap.test('Hapi router introspection', function(t) {
   t.test('using `pre` config option', function(t) {
     agent.on('transactionFinished', utils.verifier(t))
 
+    server.method('test', function(arg, next) {
+      t.ok(agent.getTransaction(), 'transaction available in server method')
+      next()
+    })
+
     var route = {
       method: 'GET',
       path: '/test/{id}',
@@ -99,6 +104,9 @@ tap.test('Hapi router introspection', function(t) {
             t.ok(agent.getTransaction(), 'transaction available in plain `pre` function')
             reply()
           },
+          {
+            method: 'test'
+          },
           [
             {
               method: function nested(req, reply) {

diff --git a/test/versioned/restify/package.json b/test/versioned/restify/package.json
@@ -25,7 +25,7 @@
         "node": "^0.10"
       },
       "dependencies": {
-        "restify": ">=5.0.0 <6.3.4 || >6.3.4",
+        "restify": ">=5.0.0 <6.3.4 || >6.3.4 <7",
         "express": "4.16"
       },
       "files": [
@@ -41,7 +41,7 @@
         "node": ">=0.11.0"
       },
       "dependencies": {
-        "restify": ">=5.0.0",
+        "restify": ">=5.0.0 <7",
         "express": "4.16"
       },
       "files": [