Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove changing unnecessary parameters in single-node.sh #1386

Merged
merged 4 commits into from
Feb 20, 2023
Merged

fix: remove changing unnecessary parameters in single-node.sh #1386

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15580c9
fix: update the overwritten parameters in single-node.sh
rach-id Feb 16, 2023
0c8806d
fix: remove unecessary `sed`s
rach-id Feb 16, 2023
10b99a6
fix: use config.toml instead of client.toml
rach-id Feb 17, 2023
ecdfb35
Update scripts/single-node.sh
rach-id Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions scripts/single-node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ celestia-appd collect-gentxs
# Set proper defaults and change ports
# If you encounter: `sed: -I or -i may not be used with stdin` on MacOS you can mitigate by installing gnu-sed
# https://gist.github.com/andre3k1/e3a1a7133fded5de5a9ee99c87c6fa0d?permalink_comment_id=3082272#gistcomment-3082272
sed -i'.bak' 's#"tcp://127.0.0.1:26657"#"tcp://0.0.0.0:26657"#g' ~/.celestia-app/config/config.toml
Copy link
Member Author

@rach-id rach-id Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note for reviewers]
this was moved to the client.toml file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when was this moved? it appears to be on line 91 of v0.12.0-rc7

Copy link
Member Author

@rach-id rach-id Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently sometime between v0.12.0-rc7 and latest master. I checked the history and it seems that only this 990c720 touches on similar stuff. Want me to investigate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two separate fields being discussed here. With a fresh celestia-appd init foo, I observe:

config.toml

# TCP or UNIX socket address for the RPC server to listen on
laddr = "tcp://127.0.0.1:26657"

client.toml

# <host>:<port> to Tendermint RPC interface for this chain
node = "tcp://localhost:26657"

Copy link
Member

@evan-forbes evan-forbes Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compiled main and reintiated, and for me I'm still seeing the line on 91 of config.toml

edit: sorry github didn't update fast enough and I didn't see the above comment before posting mine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootulp Yes, just checked, we have both. Which refer to what? I guess they're the same no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client.toml contains the default configuration for running commands, cosmos/cosmos-sdk#8953.
So, I will revert the change: 10b99a6

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 23 still needs to be reverted to

sed -i'.bak' 's#"tcp://127.0.0.1:26657"#"tcp://0.0.0.0:26657"#g' ~/.celestia-app/config/config.toml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, messed the address

sed -i'.bak' 's/timeout_commit = "25s"/timeout_commit = "1s"/g' ~/.celestia-app/config/config.toml
sed -i'.bak' 's/timeout_propose = "3s"/timeout_propose = "1s"/g' ~/.celestia-app/config/config.toml
sed -i'.bak' 's/index_all_keys = false/index_all_keys = true/g' ~/.celestia-app/config/config.toml
rach-id marked this conversation as resolved.
Show resolved Hide resolved
sed -i'.bak' 's/mode = "full"/mode = "validator"/g' ~/.celestia-app/config/config.toml
sed -i'.bak' 's#"tcp://localhost:26657"#"tcp://0.0.0.0:26657"#g' ~/.celestia-app/config/client.toml

# Start the celestia-app
celestia-appd start