Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query signal tally after successful try upgrade (backport #4045) #4052

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 25, 2024

Closes #4007

Testing

Using the updated single-node.sh script (see other PR), I can query the version tally even after a successful try upgrade.

$ ./scripts/upgrade-to-v3.sh

$ celestia-appd query signal tally 3
threshold_power: "4167"
total_voting_power: "5000"
voting_power: "5000"
```<hr>This is an automatic backport of pull request #4045 done by [Mergify](https://mergify.com).

Closes #4007

## Testing

Using the updated single-node.sh script (see other PR), I can query the
version tally even after a successful try upgrade.

```
$ ./scripts/upgrade-to-v3.sh

$ celestia-appd query signal tally 3
threshold_power: "4167"
total_voting_power: "5000"
voting_power: "5000"
```

(cherry picked from commit 0bfd074)
@mergify mergify bot requested a review from a team as a code owner November 25, 2024 13:52
@mergify mergify bot requested review from rootulp and ninabarbakadze November 25, 2024 13:52
@github-actions github-actions bot added the bot item was created by a bot label Nov 25, 2024
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evan-forbes evan-forbes merged commit c7bc385 into v3.x Nov 25, 2024
29 of 30 checks passed
@evan-forbes evan-forbes deleted the mergify/bp/v3.x/pr-4045 branch November 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants