Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #4160

Closed
wants to merge 4 commits into from
Closed

chore: fix typos #4160

wants to merge 4 commits into from

Conversation

Vikt0rPavlik
Copy link
Contributor

Changes

  1. test/pfm/pfm_test.go:
  • originalCelestiaBalalance -> originalCelestiaBalance
  1. test/e2e/minor_version_compatibility.go:
  • maxPermissableDiff -> maxPermissibleDiff

Description

This PR fixes two spelling mistakes:

  • Corrects "Balalance" to "Balance" in variable name
  • Fixes "Permissable" to "Permissible" in constant name

These changes improve code readability and maintain consistent terminology without affecting functionality. All tests should continue to pass.

@Vikt0rPavlik Vikt0rPavlik requested a review from a team as a code owner December 25, 2024 15:54
@Vikt0rPavlik Vikt0rPavlik requested review from cmwaters and ninabarbakadze and removed request for a team December 25, 2024 15:54
Copy link
Contributor

coderabbitai bot commented Dec 25, 2024

📝 Walkthrough

Walkthrough

The pull request introduces minor corrections across three files in the test directory. Changes include a correction of a variable name in the MinorVersionCompatibility function, the removal of the entire content of the README.md file in the test/interchain directory, and a fix of a typographical error in a variable name within the TestPacketForwardMiddlewareTransfer function. The modifications are primarily cosmetic and do not impact the core functionality of the tested components.

Changes

File Change Summary
test/e2e/minor_version_compatibility.go Corrected variable name from maxPermissableDiff to maxPermissibleDiff
test/interchain/README.md Removed entire content of the file
test/pfm/pfm_test.go Fixed typo in variable name from originalCelestiaBalalance to originalCelestiaBalance

Sequence Diagram

No sequence diagram is necessary for these changes, as they are primarily typographical corrections that do not modify the underlying logic or control flow of the code.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce90f23 and 9e8920e.

📒 Files selected for processing (1)
  • test/interchain/README.md (0 hunks)
💤 Files with no reviewable changes (1)
  • test/interchain/README.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp changed the title Fix typos in variable names and constants chore: fix typos Jan 2, 2025
@@ -3,7 +3,7 @@
This folder contains tests that use [interchaintest](https://github.com/strangelove-ventures/interchaintest) to assert IBC features work as expected. Candidates for testing include:

1. Interchain Accounts (ICA)
1. Packet Forward Middleware (PFM)
2. Packet Forward Middleware (PFM)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a typo. It's possible to have numbered lists like this in markdown. https://www.markdownguide.org/basic-syntax/#ordered-lists

Suggested change
2. Packet Forward Middleware (PFM)
1. Packet Forward Middleware (PFM)

@celestia-bot celestia-bot requested a review from rootulp January 2, 2025 10:19
@Vikt0rPavlik Vikt0rPavlik closed this by deleting the head repository Jan 2, 2025
@Vikt0rPavlik
Copy link
Contributor Author

@rootulp #4171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants