Code

Spec compliant merge shares#261

Code

Merged

evan-forbes merged 35 commits intomastercelestiaorg/celestia-core:masterfrom evan/merge-sharescelestiaorg/celestia-core:evan/merge-sharesCopy head branch name to clipboardApr 6, 2021

+831-161

Commits

Commits on Mar 31, 2021

• start spec compliant share merging

  evan-forbes

  committed
  494db15

Commits on Apr 1, 2021

• refactor and finish unit testing

  evan-forbes

  committed
  0d15df4

• whoops

  evan-forbes

  committed
  3f0d808

• linter gods

  evan-forbes

  committed
  8535122

• fix initial changes and use constants

  evan-forbes

  committed
  8bae88b

• use constant

  evan-forbes

  committed
  cbb5d76

• more polish

  evan-forbes

  committed
  b523831

• docs fix

  Show description for f0f38a6
  

  evan-forbes

  and

  liamsi

  authored
  f0f38a6

• review feedback: docs and out of range panic protection

  evan-forbes

  committed
  014a00e

• review feedback: add panic protection from empty input

  evan-forbes

  committed
  0896a3b

• use constant instead of recalculating ShareSize

  Show description for 96eafc7
  

  evan-forbes

  and

  adlerjohn

  authored
  96eafc7

• don't redeclare existing var

  Show description for c3d897a
  

  evan-forbes

  and

  adlerjohn

  authored
  c3d897a

• be more explicit with returned nil

  Show description for 28f9769
  

  evan-forbes

  and

  adlerjohn

  authored
  28f9769

• use constant instead of recalculating ShareSize

  Show description for 9ff16f5
  

  evan-forbes

  and

  adlerjohn

  authored
  9ff16f5

• review feedback: use consistent capitalization

  evan-forbes

  committed
  39ce26a

• stop accepting reserved namespaces as normal messages

  evan-forbes

  committed
  8794411

• use a descriptive var name for message length

  evan-forbes

  committed
  2b28c59

• linter and comparison fix

  evan-forbes

  committed
  d118716

Commits on Apr 2, 2021

• reorg tests, add test for parse delimiter, DataFromBlock and fix evidence marshal bug

  evan-forbes

  committed
  3ae1f79

Commits on Apr 3, 2021

• catch error for linter

  evan-forbes

  committed
  dfe2a07

• update test MakeShares to include length delimiters for the SHARE_RESERVED_BYTE

  evan-forbes

  committed
  e9f3a2e

• minor iteration change

  evan-forbes

  committed
  221b0fb

• refactor share splitting to fix bug

  evan-forbes

  committed
  37316e8

Commits on Apr 4, 2021

• fix all bugs with third and final refactor

  evan-forbes

  committed
  e3736d6

• Merge branch 'master' into evan/merge-shares

  evan-forbes

  committed
  632bb37

• fix conflict

  evan-forbes

  committed
  3ca2afa

• revert unnecessary changes

  evan-forbes

  committed
  0f930fd

Commits on Apr 5, 2021

• review feedback: better docs

  Show description for 91c3989
  

  evan-forbes

  and

  liamsi

  authored
  91c3989

• reivew feedback: add comment for safeLen

  evan-forbes

  committed
  043812d

• review feedback: remove unnecessay comments

  evan-forbes

  committed
  76d7a4b

• review feedback: split up share merging and splitting into their own files

  evan-forbes

  committed
  1cb4030

• review feedback: more descriptive var names

  evan-forbes

  committed
  a88db3b

• fix accidental change

  evan-forbes

  committed
  2aad8fd

• add some constant docs

  evan-forbes

  committed
  887aa08

• spelling error

  evan-forbes

  committed
  40a57c1