Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve inaccuracies around exposing consensus node's RPC #1095

Merged
merged 3 commits into from
Oct 2, 2023
Merged

chore: resolve inaccuracies around exposing consensus node's RPC #1095

merged 3 commits into from
Oct 2, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Sep 28, 2023 •
edited
Loading

note: after this is implemented, i plan to complete #556

Overview

Resolves #522

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein
chore: resolve inaccuracies around exposing consensus node's RPC
8996e36 
note: after this is implemented, i plan to complete #556
@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 28, 2023
@jcstein jcstein requested a review from cmwaters September 28, 2023 17:39
@jcstein jcstein self-assigned this Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1095/
on branch gh-pages at 2023-09-29 21:24 UTC

@jcstein jcstein marked this pull request as ready for review September 29, 2023 17:37
cmwaters
cmwaters approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this

@jcstein
Copy link
Member Author

jcstein commented Oct 2, 2023

you're welcome, thank you for the descriptive issue!

@jcstein jcstein merged commit a3184d4 into main Oct 2, 2023
4 checks passed
@jcstein jcstein deleted the jcs/issue-522 branch October 2, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

Assignees

@jcstein jcstein

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccuracies around exposing consensus node's RPC
2 participants
@jcstein @cmwaters