Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consolidate consensus nodes into one page #1107

Merged
merged 13 commits into from
Oct 4, 2023
Merged

chore: consolidate consensus nodes into one page #1107

merged 13 commits into from
Oct 4, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 4, 2023 •
edited
Loading

Overview

Replaces #1101 - learned a lesson here.

Resolves #556
Resolves #505

  1. Tested with full node
  2. tested with self-delegation to valoper address
  3. tested registering validator
  4. tested registering evm address for qgb

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from rootulp October 4, 2023 15:22
@jcstein jcstein self-assigned this Oct 4, 2023
@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-04 18:04 UTC

@jcstein jcstein force-pushed the jcs/consensus-nodes branch from ef22e8e to ae07d10 Compare October 4, 2023 15:53
rootulp
rootulp approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! I did a quick scan of https://docs.celestia.org/pr-preview/pr-1107/nodes/consensus-node/ and the rendered output LGTM

docs/developers/celestia-app-vesting.md Outdated Show resolved Hide resolved
docs/nodes/consensus-node.mdx Outdated Show resolved Hide resolved
docs/nodes/consensus-node.mdx Outdated Show resolved Hide resolved
docs/nodes/consensus-node.mdx Outdated Show resolved Hide resolved
docs/nodes/consensus-node.mdx Outdated Show resolved Hide resolved
@jcstein jcstein merged commit 564bccb into main Oct 4, 2023
4 checks passed
@jcstein jcstein deleted the jcs/consensus-nodes branch October 4, 2023 18:02
@jcstein jcstein mentioned this pull request Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

Assignees

@jcstein jcstein

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider consolidating consensus and validator pages on docs Add CLI start to consensus validating node
2 participants
@jcstein @rootulp