Update network-upgrade-process.md #1768
Conversation
Temp hotfix for 2 weeks upgrade timeline
WalkthroughThe pull request modifies the document on the Celestia network upgrade process, specifically adjusting the activation timeline for upgrades from one week to two weeks following the signaling of 5/6 of the voting power. It clarifies that the upcoming Ginger network upgrade will be the first to use the new in-protocol signaling mechanism from CIP-10. The overall structure remains intact, detailing the upgrade process and referencing the Lemongrass upgrade as a significant prior event. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
how-to-guides/network-upgrade-process.md (1)
41-41: Consider adding more specific validator guidanceWhile the two-week timeline is clearly stated and consistent with the earlier section, consider adding practical guidance for validators about this extended timeline. For example:
- When validators should ideally signal to ensure a smooth upgrade
- How to monitor the signaling progress
- What happens if the 5/6 threshold isn't met
Would you like me to help draft additional guidance text for validators?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- how-to-guides/network-upgrade-process.md (2 hunks)
🔇 Additional comments (2)
how-to-guides/network-upgrade-process.md (2)
26-26: LGTM: Timeline update is clear and well-documentedThe change from one week to two weeks for upgrade activation is clearly stated and properly contextualized within the in-protocol signaling mechanism section.
Line range hint
26-41: Verify impact on upgrade datesThe change from one week to two weeks may affect any planned upgrade dates mentioned elsewhere in the documentation.
✅ Verification successful
Let me try a different search strategy to find any potential timeline references.
Based on the search results, I can now provide a final response:
No timeline adjustments needed in other documentation files
The change from one week to two weeks for upgrade activation in the network-upgrade-process.md file does not require any adjustments to other documentation files. The search results show that:
- Other documentation files reference the network upgrade process page for specific details rather than duplicating the timeline information
- The only mentions of weeks in other files are unrelated to the upgrade activation period:
- References to block sync duration (~3 weeks)
- General scheduling information for meetups and events
- Unrelated timeline references for other processes
The documentation maintains proper separation of concerns by centralizing the upgrade activation timeline details in the network-upgrade-process.md file and having other files link to it for the specifics.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any mentions of specific dates or timelines in other documentation files # that might need to be updated due to the timeline change echo "Searching for potential timeline references that might need updates..." rg -i --type md "upgrade.*\b(date|schedule|timeline|week)" --glob '!network-upgrade-process.md'Length of output: 248
Script:
#!/bin/bash # Search for any mentions of upgrade timelines or dates using broader patterns echo "Searching for upgrade-related content..." rg -i --type md "(upgrade|timeline|schedule|activation)" -A 3 -B 3 --glob '!network-upgrade-process.md' # Also check specifically for any numerical references to weeks echo -e "\nSearching for week-related mentions..." rg -i --type md "\b\d+\s*(week|wk)" --glob '!network-upgrade-process.md'Length of output: 31996
Temp hotfix for 2 weeks upgrade timeline
Overview
Summary by CodeRabbit