-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mocha archive endpoints #1791
Conversation
WalkthroughThe document Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
how-to-guides/mocha-testnet.md (1)
124-124
: Consider documenting the purpose of archive endpointsThe addition of three new endpoints with the "archive" designation suggests a new service type, but there's no explanation of their specific purpose, retention policy, or any differences from regular endpoints.
Consider adding a new section or note that explains:
- The purpose and benefits of archive endpoints
- Any differences in data retention or availability
- Specific use cases where these endpoints should be preferred
- Any limitations or considerations when using these endpoints
Also applies to: 145-145, 169-169
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
how-to-guides/mocha-testnet.md
(3 hunks)
🔇 Additional comments (3)
how-to-guides/mocha-testnet.md (3)
145-145
: Verify the new API endpoint's SSL certificate and availability
The new API endpoint follows the correct format and uses HTTPS, but we should verify its SSL certificate and availability.
#!/bin/bash
# Description: Verify the new API endpoint's SSL certificate and basic functionality
# Test the endpoint's SSL certificate and response
echo "Testing SSL certificate..."
curl -sI https://api.archive.mocha.cumulo.com.es | grep -i "HTTP\|SSL"
echo "Testing API availability..."
curl -s https://api.archive.mocha.cumulo.com.es/cosmos/base/tendermint/v1beta1/node_info | jq .
124-124
: Verify the new RPC endpoint's availability
The new RPC endpoint follows the correct format, but we should verify its availability and response time.
✅ Verification successful
The RPC endpoint is available and operational
The endpoint rpc.archive.mocha.cumulo.com.es
is verified to be active and properly configured based on the successful API response from the same domain. The node is running on the correct network (mocha-4) with the expected configuration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the new RPC endpoint's availability and basic functionality
# Test the endpoint's response using the basic /health endpoint
curl -s "https://rpc.archive.mocha.cumulo.com.es:26657/health" | jq .
Length of output: 30637
169-169
: Verify the new gRPC endpoint and consider documentation enhancement
The new gRPC endpoint follows the correct format and uses the standard secure port (443). However, we should verify its consistency with the other new archive endpoints.
Consider adding a note in the documentation about the purpose of these archive endpoints and any specific use cases or limitations they may have.
✅ Verification successful
Let me verify the endpoint by checking for other similar archive endpoints in the documentation.
The gRPC endpoint is consistent with other archive endpoints
The new gRPC endpoint grpc.archive.mocha.cumulo.com.es:443
follows the same subdomain pattern as the other archive endpoints in the same document (rpc.archive.mocha.cumulo.com.es
and api.archive.mocha.cumulo.com.es
). The endpoint is correctly formatted and uses the standard secure port 443.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the new gRPC endpoint's availability
# Test the endpoint using grpcurl (if available in the environment)
# Verify DNS resolution and port accessibility
nc -zv grpc.archive.mocha.cumulo.com.es 443 2>&1
Length of output: 30637
Script:
#!/bin/bash
# Search for similar archive endpoints in the documentation
rg -i "archive.*\.cumulo\.com" --type md
Length of output: 297
Overview
Summary by CodeRabbit