Various improvements #109
Various improvements #109
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicolasbrugneaux
force-pushed
the
fix/various
branch
from
220b896 to
6df3373
Compare
| ); | ||
| expect(request.twitterUrl).toBe('https://example.com/x'); | ||
| expect(request.verificationUrl).toBe('https://example.com/verification'); | ||
| expect(request.websiteUrl).toBe('https://example.com'); |
There was a problem hiding this comment.
the reason I'd rather leave the snapshot is that if we add new fields to the form then it has to be added here explicitly
and we're missing checking for the file properties like mime type and size in this case
There was a problem hiding this comment.
the timestamp kept changing that's the reason
There was a problem hiding this comment.
the file's created at
| }), | ||
| } as Chain; | ||
|
|
||
| // TODO: too complex, refactor this |
There was a problem hiding this comment.
still valid need to do it
src/features/governance/hooks/__snapshots__/useProposalQuorum.test.ts.snap
Outdated
Show resolved
Hide resolved
| balance: BigInt(formatEther(TEST_BALANCE)), | ||
| gasPrice: TEST_GAS_PRICE, | ||
| gasLimit: TEST_GAS_LIMIT, | ||
| forkUrl: ANVIL_FORK_URL, |
There was a problem hiding this comment.
do we still need to fork at all?
| @@ -52,7 +54,7 @@ function DelegatorsTableContent({ delegatee }: { delegatee: Delegatee }) { | |||
| {tableData.map((row) => ( | |||
| <tr key={row.label}> | |||
| <td className="py-2 font-mono text-sm text-taupe-600"> | |||
| <ShortAddress address={row.label as `0x${string}`} /> | |||
| <ShortAddress address={row.address!} /> | |||
There was a problem hiding this comment.
what happens when the address has a name?
There was a problem hiding this comment.
If you look at the table data, the object is defined as following:
label: address,
value: fromWei(delegatorToAmount[address]),
address: normalizeAddress(address),
I purely used the .address! to prevent type cast as well as having normalized addresses
|
i think all my suggestions are either quick fixes or if they turn out not to be not something to block merging for. |
|
With the christmas holiday approaching, we decided to merge this in the new year to prevent deploying when we're off, will work on the |
This PR introduces various refactors and features that aim to fix the following tickets:
It also adds a new testing environment (anvil), fairly basic for now but at leat can serve as a good dev base for the future. It also adds supports for custom RPC urls via an environment variable
Closes:
Others: