Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LuukDAO profile with new image without spacing #26

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Add LuukDAO profile with new image without spacing #26

merged 4 commits into from
Aug 19, 2024

Conversation

LuukDAO
Copy link
Contributor

@LuukDAO LuukDAO commented Aug 12, 2024

No description provided.

@LuukDAO LuukDAO requested review from jmrossy and a team as code owners August 12, 2024 18:31
Copy link

vercel bot commented Aug 12, 2024

@LuukDAO is attempting to deploy a commit to the Celo Ecosystem Project Hosting Team on Vercel.

A member of the Team first needs to authorize it.

aaronmgdr
aaronmgdr previously approved these changes Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celo-mondo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 5:38pm

@aaronmgdr
Copy link
Member

@LuukDAO approved but you will need to fix the prettier lint issue before we can merge

@LuukDAO
Copy link
Contributor Author

LuukDAO commented Aug 14, 2024

@LuukDAO approved but you will need to fix the prettier lint issue before we can merge

Can you articulate what I should do to fix this issue? I believe you're allowed to overwrite my request? If so - can you fix it for me?

@LuukDAO
Copy link
Contributor Author

LuukDAO commented Aug 19, 2024

Hey @aaronmgdr please let me know what I should change

@aaronmgdr
Copy link
Member

hey @LuukDAO

my apologiese the short answer is to run yarn prettier. and commit the changes. but that assumes you pulled the repo and made the changes locally.

the better answer is that that would show you something like below (you need to add a space after Public Good and before SuperChain.)

Working on automating this because the experience sucks for all currently

-"interests": ["ReFi", "Stablecoins", "DeFi", "Public Goods","Superchain"],
+"interests": ["ReFi", "Stablecoins", "DeFi", "Public Goods", "Superchain"],

@aaronmgdr aaronmgdr enabled auto-merge August 19, 2024 17:38
@aaronmgdr aaronmgdr merged commit 8008e59 into celo-org:main Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants